Allow rbd mirroring mode to be set to none #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the rbd-mirroring-mode for a Ceph pool to be specified as 'none'. This allows a charm to be able to explicitly disable rbd mirroring when it knows it will be creating a pool type which is not supported. The example for this, is when erasure coded pools are being created for RBD use. Two pools are created, one for erasure coded data and one for RBD metadata. Neither pool should be mirrored, so the charm can explicitly specify this. Closes-Bug: #1898504 (cherry picked from commit c3bd490)
|
H @wolsen what's the status of this change, please? It's targeted against stable/21.04 which is now EOL (due to charmhub migration), and thus I was wondering if we can close it? Also the associated gerrit review at https://review.opendev.org/c/openstack/charm-cinder-ceph/+/784871 and the bug at https://bugs.launchpad.net/charm-ceph-rbd-mirror/+bug/1898504? Thanks! |
ajkavanagh
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the rbd-mirroring-mode for a Ceph pool to be specified as
'none'. This allows a charm to be able to explicitly disable rbd
mirroring when it knows it will be creating a pool type which is
not supported.
The example for this, is when erasure coded pools are being created
for RBD use. Two pools are created, one for erasure coded data and
one for RBD metadata. Neither pool should be mirrored, so the charm
can explicitly specify this.
Closes-Bug: #1898504
(cherry picked from commit c3bd490)