New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for use of service tokens #740
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration
wolsen
requested changes
Sep 30, 2022
charmhelpers/contrib/openstack/templates/section-keystone-authtoken-mitaka
Outdated
Show resolved
Hide resolved
* Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version
wolsen
reviewed
Nov 18, 2022
wolsen
approved these changes
Nov 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
drencrom
added a commit
to drencrom/charm-helpers
that referenced
this pull request
Mar 1, 2023
Copy parameters added in pull request juju#740 to the newest keystone-authtoken template.
drencrom
added a commit
to drencrom/charm-helpers
that referenced
this pull request
Mar 3, 2023
Copy parameters added in pull request juju#740 to the newest keystone-authtoken template.
openstack-mirroring
pushed a commit
to openstack/charm-nova-compute
that referenced
this pull request
Mar 27, 2023
This sync includes this patch to charm helpers: juju/charm-helpers#757 which is an extension of this one: juju/charm-helpers#740 and both are meant to include templates to configure service tokens in juju charms as shown in this lp bug: Related-Bug: #1992840 Change-Id: I5a5564f3e50fc09dc905b6a8f49256886d3c6a69
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Mar 27, 2023
* Update charm-nova-compute from branch 'master' to cc5d6234c7060241068d48b47be0f43375cf2b7b - Sync with charm-helpers This sync includes this patch to charm helpers: juju/charm-helpers#757 which is an extension of this one: juju/charm-helpers#740 and both are meant to include templates to configure service tokens in juju charms as shown in this lp bug: Related-Bug: #1992840 Change-Id: I5a5564f3e50fc09dc905b6a8f49256886d3c6a69
openstack-mirroring
pushed a commit
to openstack/charm-cinder
that referenced
this pull request
May 17, 2023
This sync includes this patch to charm helpers: juju/charm-helpers#757 which is an extension of this one: juju/charm-helpers#740 and both are meant to include templates to configure service tokens in juju charms as shown in this lp bug: Related-Bug: #1992840 Change-Id: Ib273f50d620160f62cbb3d6f5789bf334a7d6333
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 17, 2023
* Update charm-cinder from branch 'master' to 739aed0a14ed842bd8d83f3aaa8654ceeedcc780 - Sync with charm-helpers This sync includes this patch to charm helpers: juju/charm-helpers#757 which is an extension of this one: juju/charm-helpers#740 and both are meant to include templates to configure service tokens in juju charms as shown in this lp bug: Related-Bug: #1992840 Change-Id: Ib273f50d620160f62cbb3d6f5789bf334a7d6333
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
May 19, 2023
This sync includes these patches to charm helpers: juju/charm-helpers#740 juju/charm-helpers#757 Both are meant to include templates to configure service tokens in juju charms as shown in this lp bug: Related-Bug: #1992840 Change-Id: I31e95e227f82a4049d5f639516ed4ef5ef52d354
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
May 19, 2023
* Update charm-nova-cloud-controller from branch 'master' to 9adc198f74a7a5270acf0b295b16f004c41a2d59 - Sync with charm-helpers This sync includes these patches to charm helpers: juju/charm-helpers#740 juju/charm-helpers#757 Both are meant to include templates to configure service tokens in juju charms as shown in this lp bug: Related-Bug: #1992840 Change-Id: I31e95e227f82a4049d5f639516ed4ef5ef52d354
openstack-mirroring
pushed a commit
to openstack/charm-nova-cloud-controller
that referenced
this pull request
May 24, 2023
This sync includes these patches to charm helpers: juju/charm-helpers#740 juju/charm-helpers#757 Both are meant to include templates to configure service tokens in juju charms as shown in LP: #1992840 Change-Id: Ib9f0d6a70eb42e6cb441665511fc425cf96a1d1c Related-Bug: #1992840
ajkavanagh
pushed a commit
that referenced
this pull request
Jun 13, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request #740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com>
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
This was referenced Jun 29, 2023
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
ajkavanagh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request #740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff) Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com>
ajkavanagh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request #740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff) Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com>
ajkavanagh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request #740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff) Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com>
ajkavanagh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request #740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff) Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new template to configure the
service_user
ini file section and also add two parameters inkeystone_authtoken
configuration. These last two parameters are needed for service tokens to work properly.