-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service token support [yoga] #797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861)
* Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py
(cherry picked from commit e43008d)
ajkavanagh
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; one more review required for a stable review please.
coreycb
approved these changes
Jun 13, 2023
coreycb
approved these changes
Jun 13, 2023
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
coreycb
pushed a commit
to coreycb/charm-helpers
that referenced
this pull request
Jun 29, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request juju#740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff)
ajkavanagh
pushed a commit
that referenced
this pull request
Jun 30, 2023
* Add configuration for use of service tokens Add a new template to configure the service_user ini file section and also add two needed parameters in keystone_authtoken configuration (cherry picked from commit f8c8861) * Fixes for service tokens * Make admin role configurable * Move keystone_authtoken configuration from mitaka version to base version * Sync service_user config with keystone_authtoken for the base version (cherry picked from commit 7bcb194) Conflicts Resolved: charmhelpers/contrib/openstack/context.py * Fix tests (cherry picked from commit 4090532) * Add test for this feature (cherry picked from commit e43008d) * Fix test (cherry picked from commit c7cc5db) * Add service token parameters to last authtoken template Copy parameters added in pull request #740 to the newest keystone-authtoken template. (cherry picked from commit 23d838b) * Pin tox<4.0 --------- Co-authored-by: Jorge Merlino <jorge.merlino@canonical.com> (cherry picked from commit 32772ff) Co-authored-by: Felipe Reyes <felipe.reyes@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports of pull requests listed below to get support for Service Tokens in charm-helpers' stable/zed branch.