Fix version causing build signature issues #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version file was getting added to the manifest even if it wasn't created, causing a modification error stating that it was removed after the last build. It was also failing if the charm was a git repo that didn't have annotated tags instead of just using the sha.
johnsca
commented
Sep 14, 2018
| @@ -973,7 +974,7 @@ def trigger(cls, entity, target, layer, next_config): | |||
|
|
|||
| def _try_to_get_current_sha(self): | |||
| cmds = ( | |||
| ('git', 'describe', '--dirty'), | |||
| ('git', 'describe', '--dirty', '--always'), | |||
There was a problem hiding this comment.
For reference:
[johnsca@murdoch:~ … layers/vault/src] $ git describe --dirty
fatal: No names found, cannot describe anything.
[johnsca@murdoch:~ … layers/vault/src] $ git describe --dirty --always
f5ba548-dirty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version file was getting added to the manifest even if it wasn't created, causing a modification error stating that it was removed after the last build.
It was also failing if the charm was a git repo that didn't have annotated tags instead of just using the sha.