Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version causing build signature issues #445

Merged
merged 2 commits into from
Sep 14, 2018
Merged

Fix version causing build signature issues #445

merged 2 commits into from
Sep 14, 2018

Commits on Sep 14, 2018

  1. Fix formatting of warning

    @johnsca
    johnsca committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    d31ca6e View commit details
    Browse the repository at this point in the history

  2. Fix version causing build signature issues 

    The version file was getting added to the manifest even if it wasn't
created, causing a modification error stating that it was removed after
the last build.

It was also failing if the charm was a git repo that didn't have
annotated tags instead of just using the sha.
    @johnsca
    johnsca committed Sep 14, 2018
    Configuration menu
    Copy the full SHA
    7e57f75 View commit details
    Browse the repository at this point in the history