Create base scale up view for the inspector #417
Conversation
|
No QA |
|
Test FAILed. |
| */ | ||
| render: function() { | ||
| this.get('container').append(this.template()); | ||
| return this.get('container'); |
There was a problem hiding this comment.
Is there a reason you need to call this.get('container') twice here? You might just be able to store it in a variable.
There was a problem hiding this comment.
Nope just me rushing to get this out the door before you started :) fixed
|
This looks good, with the minor changes mentioned above 👍. |
|
Thanks for the review, that'll teach me to rush :) Changes made |
|
|
|
Build failed: Attempt to land pull request failed |
|
Test PASSed. |
|
Status: merge request accepted. Url: http://ci.jujugui.org:8080/job/juju-gui-merge |
Create base scale up view for the inspector This provides the basic scaffolding for the scale-up view in the inspectors. Because of a shortcoming with viewlet manager it needs to be manually rendered and destroyed by the overview viewlet.
This provides the basic scaffolding for the scale-up view in the inspectors. Because of a shortcoming with viewlet manager it needs to be manually rendered and destroyed by the overview viewlet.