Deprecate 'add-cloud --replace'. #10281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timClicks
reviewed
Jun 4, 2019
timClicks
approved these changes
Jun 4, 2019
|
|
anastasiamac
pushed a commit
to anastasiamac/juju
that referenced
this pull request
Jun 4, 2019
…eplace-26 juju#10281 ## Description of change 'add-cloud --replace' was an original way of updating existing cloud definitions locally. With the introduction of a more aligned conventionally 'update-cloud', the Juju original version is now redundant. This PR states that this option is deprecated and leads user to 'update-cloud'. It is intended to be removed in next major release. ## QA steps 1. 'juju help add-cloud' clearly messages that --replace option is deprecated. 2. when using --replace with add-cloud command (either interactive or non-interactive mode), users get notification: ``` $ juju add-cloud --replace canonistack WARNING 'add-cloud --replace' is deprecated. Use 'update-cloud' instead. ```
jujubot
added a commit
that referenced
this pull request
Jun 4, 2019
…ce-27 #10282 ## Description of change Merge pull request #10281 from anastasiamac/deprecate-add-cloud-replace-26 #10281 'add-cloud --replace' was an original way of updating existing cloud definitions locally. With the introduction of a more aligned conventionally 'update-cloud', the Juju original version is now redundant. This PR states that this option is deprecated and leads user to 'update-cloud'. It is intended to be removed in next major release. ## QA steps 1. 'juju help add-cloud' clearly messages that --replace option is deprecated. 2. when using --replace with add-cloud command (either interactive or non-interactive mode), users get notification: ``` $ juju add-cloud --replace canonistack WARNING 'add-cloud --replace' is deprecated. Use 'update-cloud' instead. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
'add-cloud --replace' was an original way of updating existing cloud definitions locally.
With the introduction of a more aligned conventionally 'update-cloud', the Juju original version is now redundant.
This PR states that this option is deprecated and leads user to 'update-cloud'. It is intended to be removed in next major release.
QA steps