Track branch with -n Option #10844
Merged
Track branch with -n Option #10844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a naive attempt at adding a tracking branch option to track the number of units in stages. It's naive in the fact that it doesn't validate if you just pass a unit type or if you pass multiple types. So it doesn't accumulate across applications and units. That requires some additional feedback to track the number of items that it has tracked.
The following just ensures that we correctly validate and guard against wrong cases when running track branch with the -n flag. This helps reduce a lot of complexity with in the state package, as we know that certain scenarios can't happen.
The following bumps the model generation version for the facade, this means that we can still support older version of model generations with out breaking.
The following ensures that we correctly handle no operations when attempting to get some units.
manadart
reviewed
Nov 4, 2019
manadart
reviewed
Nov 4, 2019
cmd/juju/model/trackbranch.go
Outdated
| } | ||
|
|
||
| // Init implements part of the cmd.Command interface. | ||
| func (c *trackBranchCommand) Init(args []string) error { | ||
| if len(args) == 0 { | ||
| return errors.Errorf("expected a branch name plus unit and/or application names(s)") | ||
| } | ||
| if c.numUnits < 0 { |
There was a problem hiding this comment.
I think we should detect somehow if the user actually passed -n 0 and return as invalid.
It would violate user expectation to pass that and have all units assigned.
There was a problem hiding this comment.
Ok, that makes sense.
manadart
requested changes
Nov 4, 2019
To ensure operators correctly enter valid values for the tracking of a branch, ensure we can verify when they do or don't enter a valid -n value. This complication arises because we want to ensure that we don't accidently allow them to track all branches when they don't want to. Also the rise in complexity is shown when we want the inverse of track all things as a non-value. Most things in juju the default value is track 1 as the default. Not the case here.
manadart
approved these changes
Nov 4, 2019
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Track branch with -n allows us to specify the number of units to
track when tracking a branch.
The -n can only be used when tracking application tags, as unit
tags only track 1 thing, so it's not valid to do so. I've added some
validation around this to ensure we don't accidentally allow this to
happen.
QA steps