Backport k8s install hook #11424
Merged
Backport k8s install hook #11424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of uniter++ work.
Ensure that the start hook is run for CAAS units with storage. Add tests for CAAS units, wait for started to attach storage.
|
Ran QA with no issues. |
mitechie
approved these changes
Apr 7, 2020
|
|
|
fix for: |
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Apr 8, 2020
#11429 ## Description of change Merge 2.7 with these PRs: #11415 destroy extra models created in migration CI test #11421 fix panic migrating application with no bindings #11424 backport k8s install hook #11426 add 2.7.6 upgrade step to fix uniter state files #11427 fix regression deploying k8s charms ## QA steps run unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Backport of PR 11119:
Enable install hook for k8s charms while skipping the install operation done by the uniter. It is not required due to the k8s pods.
Do not block storage hooks based on the install hook not having been run for CAAS units, other wise it will hang if there is storage.
QA steps
Please see qa steps from #11119
Documentation changes
https://discourse.juju.is/t/install-hook-now-called-for-kubernetes-charms/2585/2
Bug reference
https://bugs.launchpad.net/juju/+bug/1854635