Fix regression deploying k8s charms #11427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to use the controller model state when getting api address info.
howbazaar
approved these changes
Apr 8, 2020
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Apr 8, 2020
#11429 ## Description of change Merge 2.7 with these PRs: #11415 destroy extra models created in migration CI test #11421 fix panic migrating application with no bindings #11424 backport k8s install hook #11426 add 2.7.6 upgrade step to fix uniter state files #11427 fix regression deploying k8s charms ## QA steps run unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
#11407 introduced a regression when looking up controller API addresses.
This PR ensures we use the controller state when needed to get the cloud service.
QA steps
bootstrap k8s controller
deploy any k8s charm (would fail previously)
Bug reference
https://bugs.launchpad.net/juju/+bug/1871496