Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetBySpaceID to SubnetInfos #11570

Merged
merged 1 commit into from
May 14, 2020
Merged

Add GetBySpaceID to SubnetInfos #11570

merged 1 commit into from
May 14, 2020

Conversation

manadart
Copy link
Member

Description of change

Adds GetBySpaceID to SubnetInfos for retrieving subnets for a space.

QA steps

Not recruited yet; unit test verifies logic.

Documentation changes

None

Bug reference

N/A

@manadart
Copy link
Member Author

Add GetBySpaceID to SubnetInfos

hmlanigan
hmlanigan approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@hmlanigan hmlanigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manadart
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit 837de9a into juju:2.8 May 14, 2020
@manadart manadart deleted the subnet-infos-by-space branch May 14, 2020 08:01
@manadart manadart mentioned this pull request May 14, 2020
Merged
jujubot added a commit that referenced this pull request May 14, 2020
@jujubot
Merge pull request #11577 from manadart/2.8-into-develop
b15be43 
#11577

Merge from the 2.8 branch to bring forward:
- #11576 from manadart/interface-infos-hierarchy
- #11575 from howbazaar/update-2.8
- #11570 from manadart/subnet-infos-by-space
- #11563 from manadart/2.8-backfill-origin
- #11556 from hpidcock/fix-gomod-tests
- #11554 from wallyworld/2.8
@manadart manadart mentioned this pull request May 28, 2020
Merged
jujubot added a commit that referenced this pull request May 28, 2020
@jujubot
Merge pull request #11637 from manadart/2.8-rc
db0bdd4 
#11637

## Description of change

Cherry picked commits constituting the following patches:
- #11570
- #11606 
- #11608 

These are performance enhancements around the frequency of database access when materialising space information via `network.AllSpaceInfos`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmlanigan hmlanigan hmlanigan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@manadart @hmlanigan @jujubot