Create the charmhub refresher #12038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRichardson
force-pushed
the
charmhub-refresher
branch
from
8c23c9e
to
1836b71
Compare
hmlanigan
approved these changes
Sep 22, 2020
| charmResolver: charmResolver, | ||
| charmURL: cfg.CharmURL, | ||
| charmRef: cfg.CharmRef, | ||
| channel: cfg.Channel, |
There was a problem hiding this comment.
Can we pass an origin here instead? To ensure the correct ID is run. Or do you intend to change that in the follow ups?
| return nil, errors.Trace(err) | ||
| } | ||
|
|
||
| curl, _, err := store.AddCharmFromURL(r.charmAdder, newURL, origin, r.force) |
There was a problem hiding this comment.
I'm wondering whether ignoring the returned origin is okay or not. Where do you know that it has the correct revision and channel for the new charm to be install?
There was a problem hiding this comment.
I have no idea, was going to ask you the exact same question
The following updates the charmhub refresher to correctly handle charmhub vs charmstore function calls. Essentially because we don't have macaroons then we don't want to end up falling into the AddCharmWithAuthorization workflow. By removing the special case we can correctly reason about what the path the charmhub refresher will take. In an ideal world we would use a better pattern for dealing with this. Maybe resort to a stragtegy, but generally just embedding the functionality into two different types also resolves this.
The following ensures that the tests correctly test that the series is passed through to the function calls.
SimonRichardson
force-pushed
the
charmhub-refresher
branch
from
c50d8cf
to
d9afa31
Compare
|
|
1 similar comment
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The following updates the charmhub refresher to correctly handle
charmhub vs charmstore function calls. Essentially because we don't have
macaroons then we don't want to end up falling into the
AddCharmWithAuthorization workflow. By removing the special case we can
correctly reason about what the path the charmhub refresher will take.
In an ideal world we would use a better pattern for dealing with this.
Maybe resort to a stragtegy, but generally just embedding the
functionality into two different types also resolves this.
QA steps
Unsure here?