Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the charmhub refresher #12038

Merged
merged 3 commits into from
Sep 23, 2020
Merged

Create the charmhub refresher #12038

merged 3 commits into from
Sep 23, 2020

Commits on Sep 23, 2020

  1. Wire up the charm refresher 

    The following updates the charmhub refresher to correctly handle
charmhub vs charmstore function calls. Essentially because we don't have
macaroons then we don't want to end up falling into the
AddCharmWithAuthorization workflow. By removing the special case we can
correctly reason about what the path the charmhub refresher will take.

In an ideal world we would use a better pattern for dealing with this.
Maybe resort to a stragtegy, but generally just embedding the
functionality into two different types also resolves this.
    @SimonRichardson
    SimonRichardson committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    836bf5a View commit details
    Browse the repository at this point in the history

  2. Resolve the charmhub charm as well

    @SimonRichardson
    SimonRichardson committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    13e2b6b View commit details
    Browse the repository at this point in the history

  3. Correctly handle series in tests 

    The following ensures that the tests correctly test that the series is
passed through to the function calls.
    @SimonRichardson
    SimonRichardson committed Sep 23, 2020
    Configuration menu
    Copy the full SHA
    d9afa31 View commit details
    Browse the repository at this point in the history