Fix the validate model upgrade from a facade #12093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed originally in develop, but actually needed to be fixed in the 2.8 branch. Essentially this makes upgrading to 2.8 invalid because it expects that you already have the facade available.
manadart
approved these changes
Oct 6, 2020
|
|
This test was supposed to land together with commit d1b5f22 but was unfortunately skipped.
|
|
|
manadart
pushed a commit
to manadart/juju
that referenced
this pull request
Oct 7, 2020
juju#12093 ## Description of change This was fixed originally in develop, but actually needed to be fixed in the 2.8 branch. Essentially this makes upgrading to 2.8 invalid because it expects that you already have the facade available. ## QA steps *Please replace with how we can verify that the change works?* ```sh $ git checkout ab69570 # 2.8.3 tag $ make go-install $ juju bootstrap lxd test --build-agent $ git checkout 2.8 $ make go-install $ juju upgrade-model --build-agent ``` ## Bug reference https://bugs.launchpad.net/juju/+bug/1895963
Merged
jujubot
added a commit
that referenced
this pull request
Oct 8, 2020
#12107 Merge 2.8 bringing in these PRs: #12046 handle no application info for workload status #12049 k8s service account roles #12050 better vsphere logging #12062 run upgrade-charm after uniter restart if one is pending #12073 for bindings updateOps, only 1 per space is necessary #12070 fix rotation of k8s charms due to pod spec map ordering issue #12093 fix validation of model upgrade #12067 correct scoping of network-get to ensure public ip first #12083 pin transient dependency in operator image #12069 do not run start hook when no reboot ## QA steps See individual PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This was fixed originally in develop, but actually needed to be fixed in
the 2.8 branch. Essentially this makes upgrading to 2.8 invalid because
it expects that you already have the facade available.
QA steps
Please replace with how we can verify that the change works?
Bug reference
https://bugs.launchpad.net/juju/+bug/1895963