Merge pull request #12093 from SimonRichardson/fix-upgrade-model #12097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juju#12093 ## Description of change This was fixed originally in develop, but actually needed to be fixed in the 2.8 branch. Essentially this makes upgrading to 2.8 invalid because it expects that you already have the facade available. ## QA steps *Please replace with how we can verify that the change works?* ```sh $ git checkout ab69570 # 2.8.3 tag $ make go-install $ juju bootstrap lxd test --build-agent $ git checkout 2.8 $ make go-install $ juju upgrade-model --build-agent ``` ## Bug reference https://bugs.launchpad.net/juju/+bug/1895963
SimonRichardson
approved these changes
Oct 7, 2020
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges #12093 onto the 2.8.4 release + version increment, so we can fix model upgrades.