Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2.8 credentials support in Juju 2.9 #13128

Merged
merged 1 commit into from Jul 5, 2021

Conversation

tlm
Copy link
Member

@tlm tlm commented Jun 30, 2021

OAuth 2.8 credentials support in 2.9.

This change updates the Juju facades to return Kubernetes credential that a pre 2.9 releases can understand. This has been done through a facade bump for all users of the CloudSpec facade.

Checklist

  • Requires a pylibjuju change
  • Added integration tests for the PR
  • Added or updated doc.go related to packages changed
  • Comments answer the question of why design decisions were made

QA steps

  1. Deploy a Juju 2.8 controller with a new model and deploy a workload.
  2. Upgrade the controller to this PR
  3. Check that the workload agent and support components have no errors and are communicating with the Kubernetes api.
  4. Check controller logs for errors

Bug reference

https://bugs.launchpad.net/juju/+bug/1929910

@tlm tlm force-pushed the oauth-cred-k8s-lp1929910 branch 2 times, most recently from c311f05 to 668a95d Compare July 2, 2021 00:35
@tlm tlm changed the title OAuth 2.8 credentials OAuth 2.8 credentials support in Juju 2.9 Jul 2, 2021
@tlm tlm marked this pull request as ready for review July 2, 2021 00:37
@tlm tlm force-pushed the oauth-cred-k8s-lp1929910 branch 2 times, most recently from 6d0fd91 to 4e2b471 Compare July 2, 2021 02:18
Copy link
Member

@hpidcock hpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one issue.

@tlm tlm force-pushed the oauth-cred-k8s-lp1929910 branch from 4e2b471 to 5bc2a90 Compare July 5, 2021 00:31
This change updates the Juju facades to return Kubernetes credential
that pre 2.9 releases can understand. This has been done through a
facade bump for all users of the CloudSpec facade.
@tlm tlm force-pushed the oauth-cred-k8s-lp1929910 branch from 5bc2a90 to c3d9838 Compare July 5, 2021 02:26
@tlm
Copy link
Member Author

tlm commented Jul 5, 2021

$$merge$$

@jujubot jujubot merged commit 25e8028 into juju:2.9 Jul 5, 2021
jujubot added a commit that referenced this pull request Jul 8, 2021
#13143

### Merge 2.9 into develop

6ad00ba (upstream/2.9, origin/2.9, 2.9) Merge pull request #13142 from SimonRichardson/2.8-into-2.9-cache
f4b4ab4 Merge pull request #13140 from hpidcock/pull-secrets
185fac6 Merge pull request #13135 from wallyworld/cass-image-repo-port
2b67b0a Merge pull request #13134 from achilleasa/2.9-backport-equinix-provider-support
43b8197 (achilleasa/2.9) Merge pull request #13129 from ycliuhw/fix/lp-1934180
25e8028 Merge pull request #13128 from tlm/oauth-cred-k8s-lp1929910
7b18431 Merge pull request #13133 from SimonRichardson/pod-ready-timeout
c139c11 Merge pull request #13130 from SimonRichardson/set-config-empty-string

### Conflicts:

CONFLICT (content): Merge conflict in cmd/juju/commands/bootstrap_test.go
CONFLICT (content): Merge conflict in cloudconfig/podcfg/podcfg_test.go
CONFLICT (content): Merge conflict in cloudconfig/podcfg/image.go
CONFLICT (content): Merge conflict in cloud/clouds_test.go
CONFLICT (content): Merge conflict in apiserver/facades/client/application/application_unit_test.go
CONFLICT (content): Merge conflict in apiserver/facades/agent/uniter/uniter.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants