Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-1283] Delete old logic inside the state and upgrades packages #14168

Merged
merged 8 commits into from Jun 22, 2022
Merged

[JUJU-1283] Delete old logic inside the state and upgrades packages #14168

merged 8 commits into from Jun 22, 2022

Conversation

juanmanuel-tirado
Copy link
Contributor

@juanmanuel-tirado juanmanuel-tirado commented Jun 16, 2022

This PR removes all the logic required to run upgrades for versions earlier than 2.9.x. From now on all the logic to be maintained should be to upgrade from 2.9.x to 3.0.x. Whatever additional steps should be included to ensure an upgrade from 2.9.x to 3.0.x they have to be added in future PRs

Checklist

  • Requires a pylibjuju change
  • Added integration tests for the PR
  • Added or updated doc.go related to packages changed
  • Comments answer the question of why design decisions were made

QA steps

NA

Documentation changes

NA

Bug reference

NA

@juanmanuel-tirado juanmanuel-tirado added do not merge Even if a PR has been approved, do not merge the PR! 3.0 labels Jun 16, 2022
@juanmanuel-tirado
Copy link
Contributor Author

/build

1 similar comment
@juanmanuel-tirado
Copy link
Contributor Author

/build

@juanmanuel-tirado juanmanuel-tirado removed the do not merge Even if a PR has been approved, do not merge the PR! label Jun 20, 2022
Copy link
Member

@manadart manadart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is more stuff that can go.

upgrades/upgrade_test.go Outdated Show resolved Hide resolved
upgrades/backend.go Outdated Show resolved Hide resolved
upgrades/backend.go Outdated Show resolved Hide resolved
@hmlanigan
Copy link
Member

@juanmanuel-tirado can you please update the commit message for 13baf18? Outside of the pr it has no context.

Copy link
Member

@hmlanigan hmlanigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade from 2.9.17 to 3.0-beta1 is broken before this change, no way to test right now.

state/upgrades.go Show resolved Hide resolved
@juanmanuel-tirado juanmanuel-tirado merged commit cc7bd0b into juju:develop Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants