[JUJU-1558] Validate local bundle #14427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderici
approved these changes
Aug 4, 2022
hmlanigan
force-pushed
the
validate-local-bundle
branch
from
19299db
to
a6c04d7
Compare
|
rebased and updated go.mod/sum with charm v 8.0.2 |
LP 1983386. Validate local bundles, but allow --force to work as well.
hmlanigan
force-pushed
the
validate-local-bundle
branch
from
a6c04d7
to
b44e9fc
Compare
|
/merge |
1 similar comment
|
/merge |
jujubot
added a commit
that referenced
this pull request
Aug 12, 2022
#14452 Pull requests: - #14424 - #14428 - #14430 - #14431 - #14433 - #14434 - #14437 - #14439 - #14440 - #14442 - #14444 - #14445 - #14446 - #14448 - #14453 - Updated `github.com/juju/charm/v9` to v9.0.4. Conflicts: - apiserver/common/tools_test.go - cmd/juju/commands/upgradecontroller_test.go - cmd/juju/commands/upgrademodel_test.go - go.mod - go.sum - scripts/win-installer/setup.iss - snap/snapcraft.yaml - version/version.go Note: ignoring #14427 since this is due to be reverted (see #14449).
jujubot
added a commit
that referenced
this pull request
Aug 16, 2022
#14449 Reverts #14427 This change caused a bug to be filed with the opposite issue. Bundles exist with "extra" data well known data now. https://bugs.launchpad.net/juju/+bug/1984133 While this change is only for local bundles, there are concerns over using force flag. Though the dry-run flag could be used to get more data before using the force flag. A new approach is being developed.
Merged
jujubot
added a commit
that referenced
this pull request
Aug 20, 2022
#14488 ``` Merge branch '2.9' into develop # Conflicts: # .github/workflows/smoke.yml # apiserver/common/tools_test.go # apiserver/facades/client/application/application_unit_test.go # apiserver/facades/client/application/mock_test.go # apiserver/facades/client/application/package_test.go # apiserver/facades/client/cloud/cloudV2_test.go # apiserver/facades/client/cloud/cloud_test.go # caas/kubernetes/provider/application/application.go # cmd/juju/commands/upgradecontroller_test.go # cmd/juju/commands/upgrademodel.go # cmd/juju/commands/upgrademodel_test.go # cmd/juju/controller/kill.go # go.mod # go.sum # scripts/win-installer/setup.iss # snap/snapcraft.yaml # tests/suites/deploy/bundles/lxd-profile-bundle.yaml # tests/suites/deploy/bundles/telegraf_bundle.yaml # tests/suites/deploy/bundles/trusted_bundle.yaml # tests/suites/deploy/deploy_charms.sh # tests/suites/network/network_health.sh # tests/suites/ovs_maas/ovs_netplan_config.sh # tests/suites/spaces_ec2/juju_bind.sh # tests/suites/spaces_ec2/upgrade_charm_with_bind.sh # tests/suites/upgrade/streams.sh # upgrades/operations.go # upgrades/upgrade_test.go # version/version.go ``` Includes PRs: - #14424 - #14428 - #14430 - #14431 - #14427 - #14433 - #14434 - #14437 - #14439 - #14440 - #14442 - #14445 - #14446 - #14444 - #14448 - #14453 - #14436 - #14459 - #14462 - #14458 - #14418 - #14419 - #14463 - #14464 - #14455 - #14449 - #14465 - #14470 - #14473 - #14476 - #14468 - #14383 - #14483
jujubot
added a commit
that referenced
this pull request
Aug 30, 2022
#14474 Display bundle unmarshall errors when deploying with --dry-run. A compromise for LP1983386 and LP1984133, a rework of #14427 ## QA steps Deploy local charms, repository charms and bundles, no changes to be found. ```sh # Deploy the following bundle without force name: slurm description: A suite of codified operations to asssemble, install, deploy, and operate Slurm. website: https://omnivector-solutions.github.io/osd-documentation/master/ docs: https://omnivector-solutions.github.io/osd-documentation/master/ source: https://github.com/omnivector-solutions/slurm-bundles/ issues: https://github.com/omnivector-solutions/slurm-charms/issues series: focal applications: slurmctld: charm: slurmctld num_units: 1 contstraints: instance-type=c5a.large root-disk=20G $ juju deploy ./bundle-min.yaml --dry-run WARNING These fields document 0: line 1: unrecognized field "name" line 3: unrecognized field "website" line 4: unrecognized field "docs" line 5: unrecognized field "source" line 6: unrecognized field "issues" line 14: unrecognized field "contstraints" will be ignored during deployment ``` ## Bug reference https://bugs.launchpad.net/juju/+bug/1984133 https://bugs.launchpad.net/juju/+bug/1983386
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the response for parsing a local bundle for any UnmarshalErrors. If they exist, print and fail the deploy unless --force is used. Not done for repository bundles, who knows what havoc that might wreak.
Developer friendly structure data is available with
--logging-config "juju.charm=TRACE" --show-logQA steps
Deploy local charms, repository charms and bundles, no changes to be found.
Bug reference
https://bugs.launchpad.net/juju/+bug/1983386