Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-1588] Added 'yq' package bash-based testing system #14448

Merged

Conversation

anvial
Copy link
Member

@anvial anvial commented Aug 10, 2022

This PR adds a dependency check for yq package, changes Readme for /tests, removes installation code for yq from tests.

Checklist

  • Code style: imports ordered, good names, simple structure, etc
  • Comments saying why design decisions were made
  • [ ] Go unit tests, with comments saying what you're testing
  • [ ] Integration tests, with comments saying what you're testing
  • [ ] doc.go added or updated in changed packages

QA steps

Commands to run to verify that the change works.

cd tests
export MODEL_ARCH=arm64
export SHORT_GIT_COMMIT=ebf8545
export JUJU_VERSION=2.9.34.344
./main.sh -v -p aws deploy test_deploy_bundles

@anvial
Copy link
Member Author

anvial commented Aug 10, 2022

/merge

@wallyworld wallyworld merged commit 8b5176b into juju:2.9 Aug 10, 2022
jujubot added a commit that referenced this pull request Aug 12, 2022
#14452

Pull requests:
- #14424 
- #14428 
- #14430 
- #14431 
- #14433 
- #14434 
- #14437 
- #14439 
- #14440 
- #14442 
- #14444
- #14445 
- #14446 
- #14448
- #14453 
- Updated `github.com/juju/charm/v9` to v9.0.4.

Conflicts:
- apiserver/common/tools_test.go
- cmd/juju/commands/upgradecontroller_test.go
- cmd/juju/commands/upgrademodel_test.go
- go.mod
- go.sum
- scripts/win-installer/setup.iss
- snap/snapcraft.yaml
- version/version.go

Note: ignoring #14427 since this is due to be reverted (see #14449).
@ycliuhw ycliuhw mentioned this pull request Aug 19, 2022
jujubot added a commit that referenced this pull request Aug 20, 2022
#14488

```
Merge branch '2.9' into develop

# Conflicts:
# .github/workflows/smoke.yml
# apiserver/common/tools_test.go
# apiserver/facades/client/application/application_unit_test.go
# apiserver/facades/client/application/mock_test.go
# apiserver/facades/client/application/package_test.go
# apiserver/facades/client/cloud/cloudV2_test.go
# apiserver/facades/client/cloud/cloud_test.go
# caas/kubernetes/provider/application/application.go
# cmd/juju/commands/upgradecontroller_test.go
# cmd/juju/commands/upgrademodel.go
# cmd/juju/commands/upgrademodel_test.go
# cmd/juju/controller/kill.go
# go.mod
# go.sum
# scripts/win-installer/setup.iss
# snap/snapcraft.yaml
# tests/suites/deploy/bundles/lxd-profile-bundle.yaml
# tests/suites/deploy/bundles/telegraf_bundle.yaml
# tests/suites/deploy/bundles/trusted_bundle.yaml
# tests/suites/deploy/deploy_charms.sh
# tests/suites/network/network_health.sh
# tests/suites/ovs_maas/ovs_netplan_config.sh
# tests/suites/spaces_ec2/juju_bind.sh
# tests/suites/spaces_ec2/upgrade_charm_with_bind.sh
# tests/suites/upgrade/streams.sh
# upgrades/operations.go
# upgrades/upgrade_test.go
# version/version.go
```

Includes PRs:
- #14424
- #14428
- #14430
- #14431
- #14427
- #14433
- #14434
- #14437
- #14439
- #14440
- #14442
- #14445
- #14446
- #14444
- #14448
- #14453
- #14436
- #14459
- #14462
- #14458
- #14418
- #14419
- #14463
- #14464
- #14455
- #14449
- #14465
- #14470
- #14473
- #14476
- #14468
- #14383
- #14483
@anvial anvial deleted the JUJU-1588-add-yq-package-bash-based-testing-system branch November 2, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants