juju info: get "supports" list from Charmhub instead of metadata.yaml #14554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The series list from the metadata isn't what is available for deploy. That comes from the Charmhub API response default-release bases (which in turn comes from charmcraft and the manifest.yaml). I also remove the ad-hoc isKubernetes function here and use corecharm.IsKubernetes instead. Unfortunately due to the existing TODO in convert.go:104, we don't get the manifest.yaml and can't pass that to charmMeta / IsKubernetes, so IsKubernetes returns the wrong value for container charms, e.g., the likes of snappass-test. So snappass-test says it "supports: focal" instead of what I'd expect, "supports: kubernetes". I think we'll need to fix that in a follow-up change once ManifestYAML is provided by the Charmhub API. This commit also removes the unused Supports field from bundleInfoOutput (it was never set so always omitted).
wallyworld
approved these changes
Sep 2, 2022
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Sep 10, 2022
#14595 ``` Merge branch '2.9' into 2.9-into-develop # Conflicts: # acceptancetests/assess_cloud.py # acceptancetests/assess_endpoint_bindings.py # acceptancetests/assess_heterogeneous_control.py # state/migration_import_test.go # apiserver/facades/client/client/status.go # scripts/win-installer/setup.iss # snap/snapcraft.yaml # version/version.go ``` - #14551 - #14557 - #14560 - #14558 - #14554 - #14570 - #14577 - #14506 - #14538 - #14559 - #14574 - #14573 - #14567 - #14545 - #14541 - #14588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The series list from the metadata isn't what is available for deploy.
That comes from the Charmhub API response default-release bases (which
in turn comes from charmcraft and the manifest.yaml).
I also remove the ad-hoc isKubernetes function here and use
corecharm.IsKubernetes instead.
This commit also removes the unused Supports field from
bundleInfoOutput (it was never set so always omitted).
There are existing integration tests for
juju infothat checksupports,but only that it's present.
Checklist
Integration tests, with comments saying what you're testingdoc.go added or updated in changed packagesQA steps
# juju info [charm], then look for the "supports" field $ juju info postgresl $ juju info mysql $ juju info ubuntu $ juju info snappass-testBug reference
https://bugs.launchpad.net/juju/+bug/1988492