[JUJU-1307] Rewrote to bash based nw-resolve #14573
Conversation
| A testing charm that errors once on install hook then succeeds on the next run. | ||
| categories: | ||
| - misc | ||
| series: |
There was a problem hiding this comment.
Juju is soon to only support jammy and focal, so the rest of these should probably be dropped
| # touch ${success_file} | ||
| # status-set maintenance "Install hook succeeded." || true | ||
| # exit 0 | ||
| # fi |
There was a problem hiding this comment.
Should these comments be dropped?
| wait_for "active" '.applications["simple-resolve"] | ."application-status".current' | ||
|
|
||
| destroy_model "${model_name}" | ||
| } |
There was a problem hiding this comment.
I see that you have copied over --no-retry from the original test. function names in the test seem to imply that it is asserted in the test that the failed hook is not re-run, but this is never checked.
Worth evaluating the purpose of this test, since the original seems broken
There was a problem hiding this comment.
Do you mean to add a check that there was only ONE hook re-run (after the juju resolve --no-retry execution)?
There was a problem hiding this comment.
I've added a message wait_for ("No install hook") to check the --no-retry flag behavior.
|
/merge |
#14595 ``` Merge branch '2.9' into 2.9-into-develop # Conflicts: # acceptancetests/assess_cloud.py # acceptancetests/assess_endpoint_bindings.py # acceptancetests/assess_heterogeneous_control.py # state/migration_import_test.go # apiserver/facades/client/client/status.go # scripts/win-installer/setup.iss # snap/snapcraft.yaml # version/version.go ``` - #14551 - #14557 - #14560 - #14558 - #14554 - #14570 - #14577 - #14506 - #14538 - #14559 - #14574 - #14573 - #14567 - #14545 - #14541 - #14588
This PR added a bash-based version of the
nw-resolvetest to the deploy suite. To implement the test, thesimple-resolvecharm was copied to thetestcharmssubfolder.Checklist
QA steps
cd tests ./main.sh -v -p lxd deploy run_resolve_charm