Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would branch on if a vpc has been created. If one already exists, validate it is correctly configured or fail. However, somehow the vpc ends up incorrectly configured. Specifically the subnet disappears
So instead perform each step in setting up the vpc idempotently
Checklist
[ ] Go unit tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps
Base cases
With a 'clean' aws state (i.e. no vpcs called 'manual-deploy')
Ensure the following succeeds
This should contain output:
Now that resources have been created, run the suite again
This should contain output:
Special cases
Manually delete (detach first) the internet gateway attached to the vpc and re-run the test suite. It should succees and contain:
Manually delete the subnet in out vpc and re-run the test suite. It should succees and contain:
Manually delete the sec group called
ci-manual-deploy
and re-run the test suite. It should succees and contain: