Eliminate need for persistence in uniteravailability manifold #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using sync.WaitGroup to manage mutually-exclusive uniter operations with availability consumers. Update availability test to check whether ExitAvailability is called. Improve godoc comments. Rename manifold, hide sharp edges of waitgroups from consumers.
cmars
force-pushed
the
cmars-030-uniteravailability-wg
branch
from
71feabb
to
a5ccec2
Compare
jujubot
added a commit
that referenced
this pull request
Sep 2, 2015
Uniter sets availability Add uniteravailability resource dependency to uniter, have uniter set availability according to upgrade & started states. Prerequisite branch: http://reviews.vapour.ws/r/2509/ (#3129) (Review request: http://reviews.vapour.ws/r/2511/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait groups are used to provide the necessary mutual exclusion between workload upgrades and workers that want to interact with the agent & workload asynchronously. Availability always starts false and would be set to true only after the uniter resumes prior state from disk after restart, or otherwise enters the "started" state.
Availability consumers are expected to always
ExitAvailable()if they successfullyEnterAvailable()==true-- even if shut down withWorker.Kill.(Review request: http://reviews.vapour.ws/r/2509/)