/juju

worker/undertaker: avoid double channel close in tests #4090

Merged
merged 1 commit into from Jan 13, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mjs @jujubot
@mjs
Contributor

mjs commented Jan 13, 2016

A recent test change made during the undertaker's catacomb conversion introduced the possibility of a double channel close which seems to happen quite often under Go 1.5. This is now fixed using sync.Once to ensure that channel is only closed once.

(Review request: http://reviews.vapour.ws/r/3511/)
@mjs
worker/undertaker: avoid double channel close in tests 
A recent test change made during the undertaker's catacomb conversion
introduced the possibility of a double channel close which seems to
happen quite often under Go 1.5. This is now fixed using sync.Once to
ensure that channel is only closed once.
472e8ef
@mjs
Contributor

mjs commented Jan 13, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Jan 13, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Jan 13, 2016

@jujubot
Merge pull request #4090 from mjs/MADE-undertaker-test-panic 
worker/undertaker: avoid double channel close in tests

A recent test change made during the undertaker's catacomb conversion introduced the possibility of a double channel close which seems to happen quite often under Go 1.5. This is now fixed using sync.Once to ensure that channel is only closed once.

(Review request: http://reviews.vapour.ws/r/3511/)
0e7a524

@jujubot jujubot merged commit 0e7a524 into juju:machine-dep-engine Jan 13, 2016

@mjs mjs deleted the mjs:MADE-undertaker-test-panic branch Jan 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment