provider/manual: don't alter config in provider.Open #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Follow up to juju#429) I unintentionally changed other users of the validate function, which *shouldn't* just add defaults to the config. For example, Open should just take the config it's given.
|
LGTM |
|
Pushing this through as it fixes something I broke in a previous attempt at fixing 1347715. JFDI |
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
jujubot
added a commit
that referenced
this pull request
Jul 31, 2014
provider/manual: don't alter config in provider.Open (Follow up to #429) I unintentionally changed other users of the validate function, which *shouldn't* just add defaults to the config. For example, Open should just take the config it's given.
laszlokajtar
pushed a commit
to laszlokajtar/juju
that referenced
this pull request
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Follow up to #429)
I unintentionally changed other users of the validate
function, which shouldn't just add defaults to the
config. For example, Open should just take the config
it's given.