Make juju show take positional model. #5747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried to QA against master and when I built it I did not get it accepting the model name as the model to show. where djuju is an alias to my gopath/bin/juju |
perrito666
force-pushed
the
fix_show_model
branch
from
ee3de5e
to
c531b1b
Compare
|
QA ok with the latest changes. I was able to successfully while activated on the default model and get the details I was looking for. |
|
Does Info need an Args field now that the model name is a positional argument? |
Model is now a positional argument of juju show-model
perrito666
force-pushed
the
fix_show_model
branch
from
c531b1b
to
b0fba60
Compare
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
|
Indeed @macgreagoir tx for that input, the Args field was added before merging, cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model is now a positional argument of juju show-model.
This addresses lp:1596593