/juju

Make juju show take positional model. #5747

Merged
merged 1 commit into from Aug 10, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@perrito666 @mitechie @macgreagoir @jujubot
@perrito666
Contributor

perrito666 commented Jun 30, 2016

Model is now a positional argument of juju show-model.
This addresses lp:1596593
@mitechie
Owner

mitechie commented Aug 9, 2016

Tried to QA against master and when I built it I did not get it accepting the model name as the model to show.

$ djuju show-model controller
default: ....

where djuju is an alias to my gopath/bin/juju
@mitechie
Owner

mitechie commented Aug 10, 2016

QA ok with the latest changes. I was able to successfully

juju show-model controller

while activated on the default model and get the details I was looking for.
@macgreagoir
Contributor

macgreagoir commented Aug 10, 2016

Does Info need an Args field now that the model name is a positional argument?
@perrito666
Make juju show take positional model. 
Model is now a positional argument of juju show-model
b0fba60
@perrito666
Contributor

perrito666 commented Aug 10, 2016

$$merge$$
@jujubot
Contributor

jujubot commented Aug 10, 2016

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit 94ffe7f into juju:master Aug 10, 2016

@perrito666
Contributor

perrito666 commented Aug 10, 2016

Indeed @macgreagoir tx for that input, the Args field was added before merging, cheers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment