Add constraints to show-machine output #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes lp:1650258
|
LGTM |
voidspace
approved these changes
Jan 4, 2017
|
!!build!! |
|
!!build!! |
|
|
|
Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju |
macgreagoir
pushed a commit
to macgreagoir/juju
that referenced
this pull request
Jan 5, 2017
Add constraints to show-machine output Fixes lp:1650258 QA steps: * Bootstrap with constraints * `juju show-machine 0 -m controller` should include a constraints item, similarly formatted to the hardware item * `--format json` and `juju status`, with yaml or json format, should also include the constraints item
jujubot
added a commit
that referenced
this pull request
Jan 5, 2017
Merge pull request #6762 from macgreagoir/show-machine-constraints Add constraints to show-machine output Fixes lp:1650258 QA steps: * Bootstrap with constraints * `juju show-machine 0 -m controller` should include a constraints item, similarly formatted to the hardware item * `--format json` and `juju status`, with yaml or json format, should also include the constraints item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lp:1650258
QA steps:
juju show-machine 0 -m controllershould include a constraints item, similarly formatted to the hardware item--format jsonandjuju status, with yaml or json format, should also include the constraints item