Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update utils dependency #6775

Merged
merged 1 commit into from Jan 13, 2017
Merged

Conversation

rogpeppe
Copy link
Contributor

@rogpeppe rogpeppe commented Jan 6, 2017

This should fix https://bugs.launchpad.net/juju-core/+bug/1654528
by making juju use set of TLS cipher suites that are compatible
with the stock GnuTLS suites provided by precise and trusty.

Note that this branch is targeted at 1.25 and the utils dependency is
in the 1.25 branch of that repo.

This should fix https://bugs.launchpad.net/juju-core/+bug/1654528
by making juju use set of TLS cipher suites that are compatible
with the stock GnuTLS suites provided by precise and trusty.
Copy link
Contributor

@natefinch natefinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogpeppe
Copy link
Contributor Author

rogpeppe commented Jan 9, 2017

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 9, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 9, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9984

@anastasiamac
Copy link
Contributor

As this brings in the tip of utils dependency into 1.25, isn't it problematic? juju/utils has moved on to cater for Juju 2...
Shouldn't utils change be done on the utils version/tag/branch that 1.25 depends on?

@rogpeppe
Copy link
Contributor Author

rogpeppe commented Jan 10, 2017

Shouldn't utils change be done on the utils version/tag/branch that 1.25 depends on?

As mentioned in the PR description, that that's what it does, unless I'm missing something.

@rogpeppe
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 10, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 10, 2017

Build failed: Generating tarball failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/9994

@rogpeppe
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 11, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10003

@reedobrien
Copy link
Contributor

$$onemoretime$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 11, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10004

@rogpeppe
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 11, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 11, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10005

@reedobrien
Copy link
Contributor

$$trynow$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 12, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 12, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10006

@reedobrien
Copy link
Contributor

$$pfft$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 13, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 13, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10007

@reedobrien
Copy link
Contributor

$$spinthewheel$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 13, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Jan 13, 2017

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/10008

@rogpeppe
Copy link
Contributor Author

Another sporadic test failure, it seems. This time, it seems that mgo.Session.DatabaseNames failed with an "unexpected message" error, causing testing.resetAdminPasswordAndFetchDBNames which looks like it's come from the TLS layer.

@rogpeppe
Copy link
Contributor Author

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Jan 13, 2017

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot jujubot merged commit be69dc1 into juju:1.25 Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants