Fixes lp#1742222: intermittent failure in BundleDeployCharmStoreSuite.TestAddMetricCredentials #8287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to clarify - the order here does not matter because the test has changed... Originally, we were uploading one charm, so there was only one call made. |
axw
approved these changes
Jan 15, 2018
|
|
|
Status: merge request accepted. Url: http://ci.jujucharms.com/job/github-merge-juju |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change brings in a new testing stub check that allows to check for calls made irrespective of their order.
This PR also uses this new call in a test that failed intermittently, specifically because it did not matter in what order the calls were made to the stub... We only cared about the fact that calls were made.
QA steps
BundleDeployCharmStoreSuite.TestAddMetricCredentials does not fail.
Bug reference
https://bugs.launchpad.net/juju/+bug/1742222