Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-4488] Add licence headers to source files on 3.x #934

Merged
merged 5 commits into from Aug 23, 2023

Conversation

cderici
Copy link
Member

@cderici cderici commented Aug 22, 2023

Description

This is a forward port of #933, adding license headers to source files:

# Copyright 2023 Canonical Ltd.
# Licensed under the Apache V2, see LICENCE file for details.

QA Steps

No behavior change.

@cderici cderici added 3.2 Target juju 3.2 maintenance labels Aug 22, 2023
@cderici cderici changed the title [JUJU-4488] Add licence headers to source files [JUJU-4488] Add licence headers to source files on 3.x Aug 22, 2023
@SimonRichardson
Copy link
Member

@cderici
Copy link
Member Author

cderici commented Aug 23, 2023

@cderici you should steal this and adapt it for your needs in a github action:

https://github.com/juju/juju/blob/1206b7da23628ec1b31cf5a22ec56c8a1c6c1ab9/tests/suites/static_analysis/copyright.sh#L2-L10

ah fun, thanks!

@cderici
Copy link
Member Author

cderici commented Aug 23, 2023

The CI test failures are intermittent errors unrelated to this change. They will be fixed in a subsequent PR. /merge

@cderici
Copy link
Member Author

cderici commented Aug 23, 2023

/merge

@jujubot jujubot merged commit 28f31fa into juju:master Aug 23, 2023
6 of 8 checks passed
@cderici cderici mentioned this pull request Sep 6, 2023
jujubot added a commit that referenced this pull request Sep 7, 2023
#945

## What's Changed

* Repository Maintenance Improvements by @cderici in #922
* Stale bot to not bother feature requests by @cderici in #926
* Fix linter issues by @cderici in #928
* Fix docstring typo by @DanielArndt in #927
* Fix asyncio on README by @marceloneppel in #930
* Fix integration/test_application.test_action by @cderici in #932
* Update 3.2 facade clients by @cderici in #931
* [JUJU-4488] Add licence headers to source files on 3.x by @cderici in #934
* Update async tests to use builtin python suite by @DanielArndt in #935
* Pass correct charm url to series selector by @cderici in #942
* Green CI cleanup for python-libjuju by @cderici in #939
* Bring forward support for nested assumes expressions on 3x by @cderici in #943

### Notes

JUJU-4532

[JUJU-4488]: https://warthogs.atlassian.net/browse/JUJU-4488?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@cderici cderici mentioned this pull request Oct 26, 2023
jujubot added a commit that referenced this pull request Oct 26, 2023
#980

## What's Changed
* Repository Maintenance Improvements by @cderici in #922
* Stale bot to not bother feature requests by @cderici in #926
* Fix linter issues by @cderici in #928
* Fix docstring typo by @DanielArndt in #927
* Fix asyncio on README by @marceloneppel in #930
* Fix integration/test_application.test_action by @cderici in #932
* Update 3.2 facade clients by @cderici in #931
* [JUJU-4488] Add licence headers to source files on 3.x by @cderici in #934
* Update async tests to use builtin python suite by @DanielArndt in #935
* Pass correct charm url to series selector by @cderici in #942
* Green CI cleanup for python-libjuju by @cderici in #939
* Bring forward support for nested assumes expressions on 3x by @cderici in #943
* Release 3.2.2.0 notes by @cderici in #945
* Cleanup release process for 3.x by @cderici in #946
* Use new DeployFromRepository endpoint for deploy by @cderici in #949
* Handle pending upload resources deployfromrepository by @cderici in #953
* Optimize connection teardown by @cderici in #952
* Use `log.warning` instead of the deprecated `warn` by @sed-i in #954
* Find controller name by endpoint on 3.x track by @cderici in #966
* Optimize & fix unit removal by @cderici in #967
* Allow switch kwarg in refresh to switch to local charms by @jack-w-shaw in #971
* Parse charm URLs consistantly for local charms by @jack-w-shaw in #974
* Juju config directory location fix on 3.x by @cderici in #976
* [JUJU-4779] Ensure valid charm origin for local charm switches by @jack-w-shaw in #978
* Application refresh with resources on 3.x by @cderici in #973

#### Notes & Discussion

JUJU-4851

[JUJU-4488]: https://warthogs.atlassian.net/browse/JUJU-4488?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-4779]: https://warthogs.atlassian.net/browse/JUJU-4779?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 Target juju 3.2 maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants