Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup release process for 3.x #946

Merged
merged 7 commits into from Sep 19, 2023

Conversation

cderici
Copy link
Member

@cderici cderici commented Sep 7, 2023

Description

This clears up the release process for the master branch. Apparently I forgot to forward port some of the changes from #921 (that clears it up for the 2.9 branch).

A twine check is added for validating the release package before trying to upload it.

The sphinx sections needed a fix for the rendering of the changelog. Specific rules for sections can be found in here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections

QA Steps

The following command will do the first part of the release process where we generate a package with setup.py, and then check that package with twine check.

 $ rm -rf dist && python setup.py sdist && twine check dist/* && rm -rf dist

So this command should produce an output that says PASSED:

....
....
....
copying juju/client/proxy/factory.py -> juju-3.2.2.0/juju/client/proxy
copying juju/client/proxy/proxy.py -> juju-3.2.2.0/juju/client/proxy
copying juju/client/proxy/kubernetes/proxy.py -> juju-3.2.2.0/juju/client/proxy/kubernetes
Writing juju-3.2.2.0/setup.cfg
creating dist
Creating tar archive
removing 'juju-3.2.2.0' (and everything under it)
Checking dist/juju-3.2.2.0.tar.gz: PASSED

@cderici cderici added 3.2 Target juju 3.2 maintenance labels Sep 7, 2023
@cderici cderici changed the title Cleanup release process 3.x Cleanup release process for 3.x Sep 7, 2023
@cderici cderici requested a review from anvial September 7, 2023 16:48
Copy link
Member

@anvial anvial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, lg2m

@cderici
Copy link
Member Author

cderici commented Sep 19, 2023

/merge

@jujubot jujubot merged commit 54c49e2 into juju:master Sep 19, 2023
7 of 8 checks passed
@cderici cderici mentioned this pull request Oct 26, 2023
jujubot added a commit that referenced this pull request Oct 26, 2023
#980

## What's Changed
* Repository Maintenance Improvements by @cderici in #922
* Stale bot to not bother feature requests by @cderici in #926
* Fix linter issues by @cderici in #928
* Fix docstring typo by @DanielArndt in #927
* Fix asyncio on README by @marceloneppel in #930
* Fix integration/test_application.test_action by @cderici in #932
* Update 3.2 facade clients by @cderici in #931
* [JUJU-4488] Add licence headers to source files on 3.x by @cderici in #934
* Update async tests to use builtin python suite by @DanielArndt in #935
* Pass correct charm url to series selector by @cderici in #942
* Green CI cleanup for python-libjuju by @cderici in #939
* Bring forward support for nested assumes expressions on 3x by @cderici in #943
* Release 3.2.2.0 notes by @cderici in #945
* Cleanup release process for 3.x by @cderici in #946
* Use new DeployFromRepository endpoint for deploy by @cderici in #949
* Handle pending upload resources deployfromrepository by @cderici in #953
* Optimize connection teardown by @cderici in #952
* Use `log.warning` instead of the deprecated `warn` by @sed-i in #954
* Find controller name by endpoint on 3.x track by @cderici in #966
* Optimize & fix unit removal by @cderici in #967
* Allow switch kwarg in refresh to switch to local charms by @jack-w-shaw in #971
* Parse charm URLs consistantly for local charms by @jack-w-shaw in #974
* Juju config directory location fix on 3.x by @cderici in #976
* [JUJU-4779] Ensure valid charm origin for local charm switches by @jack-w-shaw in #978
* Application refresh with resources on 3.x by @cderici in #973

#### Notes & Discussion

JUJU-4851

[JUJU-4488]: https://warthogs.atlassian.net/browse/JUJU-4488?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[JUJU-4779]: https://warthogs.atlassian.net/browse/JUJU-4779?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2 Target juju 3.2 maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants