Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JUJU-4488] Add licence headers to source files #933

Merged
merged 6 commits into from Aug 22, 2023
Merged

[JUJU-4488] Add licence headers to source files #933

merged 6 commits into from Aug 22, 2023

Conversation

cderici
Copy link
Member

@cderici cderici commented Aug 18, 2023 •
edited

Description

This adds the following license header to the source files.

# Copyright 2023 Canonical Ltd.
# Licensed under the Apache V2, see LICENCE file for details.

QA Steps

No behavior change.

Notes & Discussion

This also fixes the tests/integration/test_charmhub.py:110 which the linter was crying about (why we didn't see that failure in the past PRs is beyond me).

@cderici cderici added 2.9 forward port please remove label after ported maintenance labels Aug 18, 2023
@cderici cderici requested review from jack-w-shaw and removed request for jack-w-shaw August 22, 2023 02:36
jack-w-shaw
jack-w-shaw approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@jack-w-shaw jack-w-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/issue829.py Outdated Show resolved Hide resolved
@cderici
Copy link
Member Author

cderici commented Aug 22, 2023

/merge

@jujubot jujubot merged commit 3edef16 into juju:2.9 Aug 22, 2023
5 of 6 checks passed
@cderici cderici mentioned this pull request Aug 22, 2023
Merged
@cderici cderici removed the forward port please remove label after ported label Aug 22, 2023
jujubot added a commit that referenced this pull request Aug 23, 2023
@jujubot
Merge pull request #934 from cderici/licence-headers-forward-port
28f31fa 
#934

#### Description

This is a forward port of #933, adding license headers to source files:

```python
# Copyright 2023 Canonical Ltd.
# Licensed under the Apache V2, see LICENCE file for details.
```

#### QA Steps

No behavior change.
@cderici cderici mentioned this pull request Sep 5, 2023
Merged
jujubot added a commit that referenced this pull request Sep 6, 2023
@jujubot
Merge pull request #944 from cderici/release-2.9.44.1
2592638 
#944

## What's Changed

This is a patch release on the `2.9` track. Most significant change is the added support for nested `assumes` expressions in #940.

* Cleanup release process by @cderici in #921
* [JUJU-4488] Add licence headers to source files by @cderici in #933
* Parse nested assumes expressions by @cderici in #940

[JUJU-4488]: https://warthogs.atlassian.net/browse/JUJU-4488?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-w-shaw jack-w-shaw jack-w-shaw approved these changes

Assignees
No one assigned
Labels
2.9 maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cderici @jack-w-shaw @jujubot