Parse nested assumes expressions #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/merge |
This was referenced Sep 4, 2023
Merged
jujubot
added a commit
that referenced
this pull request
Sep 6, 2023
#943 #### Description This forward ports the fix for nested assume expressions from #940 into the master branch. Fixes #938 for `3.x`. #### QA Steps Same QA steps can be followed from #940, so copy/pasting the manual QA steps below: ----- Unfortunately it's not trivial to write an integration test for this, as the code that's been changed is part of the facade api. So we'll use the `mysql-k8s` charm that's been used in #938. ``` $ juju version 3.x $ juju bootstrap microk8s micro28 $ juju add-model assumes-test ``` ```python $ python -m asyncio asyncio REPL 3.10.12 (main, Jun 11 2023, 05:26:28) [GCC 11.4.0] on linux Use "await" directly instead of "asyncio.run()". Type "help", "copyright", "credits" or "license" for more information. >>> import asyncio >>> from juju import model;m=model.Model();await m.connect();await m.deploy("mysql-k8s", channel="8.0/edge", trust=True) <Application entity_id="mysql-k8s"> >>> exiting asyncio REPL... ``` #### Notes & Discussion JUJU-4562
jujubot
added a commit
that referenced
this pull request
Sep 6, 2023
#944 ## What's Changed This is a patch release on the `2.9` track. Most significant change is the added support for nested `assumes` expressions in #940. * Cleanup release process by @cderici in #921 * [JUJU-4488] Add licence headers to source files by @cderici in #933 * Parse nested assumes expressions by @cderici in #940 [JUJU-4488]: https://warthogs.atlassian.net/browse/JUJU-4488?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for nested
assumesexpression. Without this change, pylibjuju could only parse 1-level ofassumes, with this change, we can support assumes expression that look like:Fixes #938
QA Steps
Unfortunately it's not trivial to write an integration test for this, as the code that's been changed is part of the facade api. So we'll use the
mysql-k8scharm that's been used in #938.Notes & Discussion
JUJU-4562