Cleanup release process #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-w-shaw
approved these changes
Jul 21, 2023
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
Sep 6, 2023
#944 ## What's Changed This is a patch release on the `2.9` track. Most significant change is the added support for nested `assumes` expressions in #940. * Cleanup release process by @cderici in #921 * [JUJU-4488] Add licence headers to source files by @cderici in #933 * Parse nested assumes expressions by @cderici in #940 [JUJU-4488]: https://warthogs.atlassian.net/browse/JUJU-4488?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
jujubot
added a commit
that referenced
this pull request
Sep 19, 2023
#946 #### Description This clears up the release process for the master branch. Apparently I forgot to forward port some of the changes from #921 (that clears it up for the 2.9 branch). A twine check is added for validating the release package *before* trying to upload it. The sphinx sections needed a fix for the rendering of the changelog. Specific rules for sections can be found in here: https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#sections #### QA Steps The following command will do the first part of the release process where we generate a package with `setup.py`, and then check that package with `twine check`. ``` $ rm -rf dist && python setup.py sdist && twine check dist/* && rm -rf dist ``` So this command should produce an output that says `PASSED`: ```sh .... .... .... copying juju/client/proxy/factory.py -> juju-3.2.2.0/juju/client/proxy copying juju/client/proxy/proxy.py -> juju-3.2.2.0/juju/client/proxy copying juju/client/proxy/kubernetes/proxy.py -> juju-3.2.2.0/juju/client/proxy/kubernetes Writing juju-3.2.2.0/setup.cfg creating dist Creating tar archive removing 'juju-3.2.2.0' (and everything under it) Checking dist/juju-3.2.2.0.tar.gz: PASSED ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes up some of the bumps in the release process (
make release).long_description_content_typein thesetup.pynote::in the readme, apparently that's not a thing in the earlier versions of sphinx, so this removes it.--repository-url https://upload.pypi.org/legacy/parameter, which is not anymore a thing (at least for our project), so we're using.pypircwith tokens (as described in the release document for pylibjuju), so this changes twine call to use--repository juju, which is simply a reference to the entry in the.pypirc.QA Steps
No QA needed.
Notes & Discussion
When forward ported, the
docs/changelog.rstin the master branch needs to be fixed (for sections/subsections). Just call and you'll see the error: