Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails on 32bit architectures #24

Open
gibmat opened this issue Nov 28, 2021 · 0 comments
Open

Test fails on 32bit architectures #24

gibmat opened this issue Nov 28, 2021 · 0 comments

Comments

@gibmat
Copy link

gibmat commented Nov 28, 2021

When tests are run on a 32bit architecture, they fail because sizeSuffixMultiplier() in size.go is defined to return/use an int and a 32bit int cannot hold the really huge suffix multipliers. A 64bit int is large enough; updating sizeSuffixMultiplier() to use int64 allows tests to pass on both 32bit and 64bit architectures.

Also, since this code was copied from juju/utils (ugh!), please be sure to fix this bug in that repository as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant