-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove convenience functions (disk
, circle
, etc.)
#29
Comments
Ah, I see, they are used because the domains are mapped domains. |
Though I think my point is still correct: |
In the absence of a type that stores a centre and radius, it seemed user-friendly to provide a routine that would return a domain that represents what the user wants. They are lower-cased because you can't predict which type they return. Right now they are indeed mapped domains. How about |
I think |
I can live with that |
Some will need to stay for now: e.g. |
There are too many convenience functions, which goes against a good practice code design principle that there should only be one way to write anything (to make find-and-replace easier, etc.). I think all the lowercase convenience functions can be removed:
UnitDisk
is just as good asdisk
, etc.The text was updated successfully, but these errors were encountered: