Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JuliaDB and NamedTuples out of sync: no create_tuple found #59

Closed
merl-dev opened this issue Jun 3, 2017 · 1 comment
Closed

JuliaDB and NamedTuples out of sync: no create_tuple found #59

merl-dev opened this issue Jun 3, 2017 · 1 comment

Comments

@merl-dev
Copy link

merl-dev commented Jun 3, 2017

Just a heads up: I noticed today that the NamedTuples.create_tuple method has been refactored / renamed but JuliaDB still contains a reference to that in utils.jl, line 359 method Base.deserialize.
@shashi shashi closed this as completed in cfcaa28 Jun 4, 2017
@shashi
Copy link
Collaborator

shashi commented Jun 4, 2017

Thanks! It looks like that change hasn't been released yet JuliaLang/METADATA.jl#9525 . I fixed it anyway to keep it working with warnings when it is released. The correct fix here is to remove the Base.serialize and Base.deserialize methods. Which I can do once a new NamedTuples is released.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shashi @merl-dev