Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more highlight options #103

Closed
ronisbr opened this issue Mar 14, 2020 · 3 comments
Closed

Provide more highlight options #103

ronisbr opened this issue Mar 14, 2020 · 3 comments

Comments

@ronisbr
Copy link
Contributor

ronisbr commented Mar 14, 2020

First of all, thanks for this amazing package! The support of Julia in Emacs is pretty good :)

However, I think there is a point that can be improved. For example, take a look at the following figure. To the left, there is a .jl file opened in Emacs, whereas, to the right, there is the same file opened in Vim.

fig

Notice that Julia mode in Vim has many more highlight options compared to Emacs. It highlights operation symbols like +, -, = and also literals. I think it is a little bit better.

Question: is it possible to add those options in Emacs?

@ronisbr
Copy link
Contributor Author

ronisbr commented Mar 18, 2020

Please, forget about this. I enabled number highlighting using the package highlight-numbers and emacs was really slow when opening files with a lot of numbers.

@ronisbr ronisbr closed this as completed Mar 18, 2020
@non-Jedi
Copy link
Contributor

It's certainly possible and might even be more efficient than what you experienced with highlight-numbers. Could you take a look at https://www.gnu.org/software/emacs/manual/html_node/elisp/Faces-for-Font-Lock.html and let me know which faces you'd like for these different kinds of highlighting?

@ronisbr
Copy link
Contributor Author

ronisbr commented Mar 18, 2020

It's certainly possible and might even be more efficient than what you experienced with highlight-numbers. Could you take a look at https://www.gnu.org/software/emacs/manual/html_node/elisp/Faces-for-Font-Lock.html and let me know which faces you'd like for these different kinds of highlighting?

Nice! This is what I get with highlight-numbers:

Captura de Tela 2020-03-17 às 21 29 34

I think it is pretty good. It uses (AFAIK) font-lock-constant-face for the numbers. For the symbols, I would propose font-lock-type-face, which seems to be the same font used for begin and end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants