Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test results of discretization methods #70

Closed
serenity4 opened this issue Mar 12, 2021 · 3 comments
Closed

Test results of discretization methods #70

serenity4 opened this issue Mar 12, 2021 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@serenity4
Copy link
Member

Keeping track of the fact that additional tests should be added for FIST, notably to test the correctness of the result. Additional tests introduced in #66 but eventually not merged in #68 included tests for the output regarding the number of triangles, connectivity coverage and vertex data.

@juliohm juliohm added the enhancement New feature or request label Mar 12, 2021
@serenity4
Copy link
Member Author

serenity4 commented Mar 13, 2021

Triangle count and vertex data tests are now implemented via #75. We may want to consider the following tests:

  • Connectivity coverage: check that all points are connected to a Triangle in the mesh.
  • Triangulation correctness: check that all triangles are simple.
  • Triangulation quality: We may want to test that several options (not implemented yet) in FIST give actual improvements (particularly if there is a cost to pay for a supposedly better quality).

Regarding this last item, we fist need to have metrics that measure the quality of a triangulation. I'll open a separate issue on that, since I think this may be very useful not just for FIST but in general.

@juliohm
Copy link
Member

juliohm commented Mar 13, 2021

Amazing. Thanks for the organizing these tests. I agree that it would be nice to have some quality metrics for mesh elements 👍🏽

I will also open other issues on my radar so that we keep things moving in parallel.

@juliohm juliohm added the good first issue Good for newcomers label Jul 27, 2021
@juliohm juliohm changed the title Test FIST results Test results of discretization methods Aug 11, 2021
@juliohm juliohm added help wanted Extra attention is needed and removed enhancement New feature or request labels Dec 10, 2021
@juliohm
Copy link
Member

juliohm commented Dec 10, 2021

Similar to the issue #77 , this issue is research-oriented. We will only find the need to implement such metrics when a bug is encountered in any of our triangulation algorithms. In that case we will fix the bug, and implement a test function as described above to avoid reintroducing the bug in the future. To keep our issue tracker clean with issues that reflect the current needs of the community, I will close this one.

@juliohm juliohm closed this as completed Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants