Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambiguity with AbstractTrees #512

Closed
timholy opened this issue Aug 28, 2021 · 0 comments · Fixed by #513
Closed

Ambiguity with AbstractTrees #512

timholy opened this issue Aug 28, 2021 · 0 comments · Fixed by #513

Comments

@timholy
Copy link
Member

timholy commented Aug 28, 2021

AbstractTrees is a dependency of SnoopCompile. Unfortunately, loading it and Colors at the same time introduces an ambguity that stands in the way of running this test suite:

julia> tinf = @snoopi_deep include("runtests.jl")
Test Failed at /home/tim/.julia/dev/Colors/test/runtests.jl:2
  Expression: isempty(detect_ambiguities(Colors, Base, Core))
   Evaluated: isempty(Tuple{Method, Method}[(getindex(M::Colors.Mat3x3{T}, i) where T in Colors at /home/tim/.julia/dev/Colors/src/utilities.jl:10, getindex(x::AbstractArray, ::AbstractTrees.ImplicitRootState) in AbstractTrees at /home/tim/.julia/packages/AbstractTrees/oHb1F/src/iteration.jl:103)])
ERROR: LoadError: There was an error during testing
@timholy timholy mentioned this issue Aug 28, 2021
Merged
timholy added a commit that referenced this issue Aug 28, 2021
@timholy
Fix an ambiguity with AbstractTrees (#513)
9b57362 
The fix is to adhere more closely to the minimalistic
[AbstractArray interface](https://docs.julialang.org/en/v1/manual/interfaces/#man-interface-array).

Fixes #512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix an ambiguity with AbstractTrees JuliaGraphics/Colors.jl
1 participant
@timholy