Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No right click in message body #173

Closed
grantthomas opened this issue Jul 7, 2021 · 14 comments · Fixed by #201
Closed

No right click in message body #173

grantthomas opened this issue Jul 7, 2021 · 14 comments · Fixed by #201
Labels
bug Something isn't working

Comments

@grantthomas
Copy link

I've recently updated to 0.3 from the 0.1.2 release.

Both versions I'm unable to right click in message bodies.

I can right click on:

  • left bar folder entires
  • emails in the middle pane
  • names in the TO and CC fields of new/reply/forward

I cannot right click:

  • Message body in reading pane / preview or pop out window in either view only or editable messages

Settings:
Logged in through application UI.
Settings file contents is blank: {}

OS: Pop OS 21.04
Env: KDE 5.21.4, SDDM
Release: 0.3 deb : https://github.com/julian-alarcon/prospect-mail/releases/download/v0.3.0/prospect-mail_0.3.0_amd64.deb
@codebori
Copy link

codebori commented Aug 9, 2021

I have the same issue.

Prospect Mail 0.3.0-275
OpenSuse Tumbleweed
KDE 5.22.4, SDDM

I also saw a similar issue here: #27

@DenisBY
Copy link

DenisBY commented Dec 1, 2021

The same on Manjaro and app version 0.3.0

@julian-alarcon
Copy link
Owner

There are some implementations on the internet.
https://stackoverflow.com/questions/63379503/electron-js-with-the-right-click-be-able-to-perform-a-copy-and-cut-if-a-sel
https://github.com/sindresorhus/electron-context-menu

Maybe someone could work on this.

@julian-alarcon julian-alarcon added the enhancement New feature or request label Dec 13, 2021
@MagiusCHE
Copy link
Contributor

should include #122 too

@MagiusCHE
Copy link
Contributor

@julian-alarcon can you assign this to me? ( so i can found in my Issue tab :-) )

@MagiusCHE MagiusCHE mentioned this issue Dec 15, 2021
Merged
@MagiusCHE
Copy link
Contributor

Done! It will be in the next PR #201
immagine

MagiusCHE added a commit to MagiusCHE/prospect-mail that referenced this issue Dec 15, 2021
@MagiusCHE
julian-alarcon#122, julian-alarcon#173 Added context menu wilth Editi…
aa43e40 
…ng actions.
@grantthomas
Copy link
Author

Thanks for the work so far @MagiusCHE, but this issue is still happening for my system after a full OS reinstall.

I am only able to right-click when replying to a message, and only when there is a spelling mistake noticed.
Even then, I do not see the full list of options you show in your screenshot.
image

However, I cannot right-click any other text in the message pane, whether in an email I am reading or in a response I am writing.

I would send a screenshot of other interactions, but with nothing happening I don't think it would be of any use.
If I run it from the console, these are the output
image

I have installed the .deb package 0.4.0 that references #128, but do not see this issue, #173 in the changelist
from here: v0.4.0 release
image

As a reference, in the Outlook.com PWA, I am seeing these behaviors when editing:
image
image

Thanks again for putting your time and effort into improving Prospect

@MagiusCHE
Copy link
Contributor

MagiusCHE commented Feb 6, 2022 •
edited

@grantthomas can you try one my releases? https://github.com/MagiusCHE/prospect-mail/releases/tag/v0.5.0-beta-tmp
i guess this feature is not merged in mainline.

(Note: i just rebuilded them just in case)

@grantthomas
Copy link
Author

Hi @MagiusCHE

Your 0.5.0-beta build works for me.
I see this behavior in the message pane

reading email
On hilight
image

on right-click
image

Composing email
right click on known word
image

Right click on misspelled word
image

This is fantastic, it seems minor but can be important to daily use.

@DenisBY
Copy link

DenisBY commented Feb 7, 2022

@MagiusCHE I couldn't find how to fill an issue in your repo. We have 2FA enabled and your version is failing to show the MFA page.

@MagiusCHE
Copy link
Contributor

MagiusCHE commented Feb 7, 2022 •
edited

@DenisBY i have just enabled Issue on my fork. https://github.com/MagiusCHE/prospect-mail/issues

@DenisBY
Copy link

DenisBY commented Feb 7, 2022

@MagiusCHE but I don't have an issue with 0.4.0. Only with your 0.5.0-beta.

@MagiusCHE
Copy link
Contributor

MagiusCHE commented Feb 7, 2022 •
edited

@MagiusCHE but I don't have an issue with 0.4.0. Only with your 0.5.0-beta.

I've enabled issue on my fork. You can write it there.

julian-alarcon added a commit that referenced this issue Jul 24, 2023
@MagiusCHE @julian-alarcon
Fixes and features (#201)
d3f474a 
* resolved package.json conflict

* fix window-controlled require electron to match recent changed in mainstream.

* fix package json about-window requirement

* #189 Force nodeIntegration and  contextIsolation to let require works again.

* Undo Force nodeIntegration and  contextIsolation to let require works again.

* fix package.json doubled lines

* #189 forced contextIsolation: false and nodeIntegration: true to let "require" workson client side.

* UnreadNumberObserver is now in a separated js file

* UnreadNumberObserver is now in a separated js file fix performance cache

* UnreadNumberObserver better tassonomy

* client js and css are now in a separated  file. Using clientInjector to load, cache and inject them.

* Multiple unreadMessageObserver handler.

* Integrated did-create-window and child-window.js suggested by @joax

* Better client injector strategy. Moved all clinet files into /public dir

* #122, #173 Added context menu wilth Editing actions.

* #122 Context menu will show first 50 chars of the clicked link url

* context-menu: undo will appear only on editable element.

* try fix clear unreadmessageicon in some cases OWA

* unread-observer "custom_2": attempting to be multilanguage

* #10 fixed Right click on child windows.

* #10 fixed Right click on child windows.

* update electron to "^16.0.5" in order to fix annoying bug described here electron/electron#31152

* update electron to "^16.0.9" in order to fix annoying bug described here electron/electron#31152

---------

Co-authored-by: Julian Alarcon <jalarcon@lendingfront.com>
Co-authored-by: Julian Alarcon <alarconj@gmail.com>
@julian-alarcon
Copy link
Owner

Fixed in #201

@julian-alarcon julian-alarcon added bug Something isn't working and removed enhancement New feature or request labels Sep 19, 2023
@julian-alarcon julian-alarcon mentioned this issue Sep 20, 2023
Merged
julian-alarcon pushed a commit that referenced this issue Nov 2, 2023
@MagiusCHE
#122, #173 Added context menu wilth Editing actions.
33143c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes and features MagiusCHE/prospect-mail
5 participants
@DenisBY @codebori @grantthomas @julian-alarcon @MagiusCHE