Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require is not defined #189

Closed
MrDaGree opened this issue Oct 21, 2021 · 2 comments · Fixed by #201
Closed

Require is not defined #189

MrDaGree opened this issue Oct 21, 2021 · 2 comments · Fixed by #201
Assignees
@MagiusCHE

Comments

@MrDaGree
Copy link

After downloading the deb package and trying to see if this would actually give me desktop notifications I get this error:

image
image
@MrDaGree MrDaGree mentioned this issue Oct 22, 2021
Closed
MagiusCHE added a commit to MagiusCHE/prospect-mail that referenced this issue Dec 13, 2021
@MagiusCHE
julian-alarcon#189 Force nodeIntegration and contextIsolation to let …
f92b7f4 
…require works again.
@MagiusCHE MagiusCHE mentioned this issue Dec 13, 2021
Merged
@MagiusCHE
Copy link
Contributor

MagiusCHE commented Dec 15, 2021 •
edited

I've commented the fix to enable contextisolation and nodeintegration during creation of BrowserWindow.
immagine

I think it is safe to enable it but we should consider Electron removed default TRUE to nodeIntegration and default FALSE to contextIsolation for security reason.

@julian-alarcon let me know if it is ok for you and i will removed the comment to fix require is not defined and let the notification system will work again.

@MagiusCHE
Copy link
Contributor

@julian-alarcon can you assign this to me? ( so i can found in my Issue tab :-) )

MagiusCHE added a commit to MagiusCHE/prospect-mail that referenced this issue Dec 15, 2021
@MagiusCHE
julian-alarcon#189 forced contextIsolation: false and nodeIntegration…
47cdf2a 
…: true to let "require" workson client side.
@MagiusCHE MagiusCHE mentioned this issue Dec 15, 2021
Merged
julian-alarcon added a commit that referenced this issue Jul 24, 2023
@MagiusCHE @julian-alarcon
Fixes and features (#201)
d3f474a 
* resolved package.json conflict

* fix window-controlled require electron to match recent changed in mainstream.

* fix package json about-window requirement

* #189 Force nodeIntegration and  contextIsolation to let require works again.

* Undo Force nodeIntegration and  contextIsolation to let require works again.

* fix package.json doubled lines

* #189 forced contextIsolation: false and nodeIntegration: true to let "require" workson client side.

* UnreadNumberObserver is now in a separated js file

* UnreadNumberObserver is now in a separated js file fix performance cache

* UnreadNumberObserver better tassonomy

* client js and css are now in a separated  file. Using clientInjector to load, cache and inject them.

* Multiple unreadMessageObserver handler.

* Integrated did-create-window and child-window.js suggested by @joax

* Better client injector strategy. Moved all clinet files into /public dir

* #122, #173 Added context menu wilth Editing actions.

* #122 Context menu will show first 50 chars of the clicked link url

* context-menu: undo will appear only on editable element.

* try fix clear unreadmessageicon in some cases OWA

* unread-observer "custom_2": attempting to be multilanguage

* #10 fixed Right click on child windows.

* #10 fixed Right click on child windows.

* update electron to "^16.0.5" in order to fix annoying bug described here electron/electron#31152

* update electron to "^16.0.9" in order to fix annoying bug described here electron/electron#31152

---------

Co-authored-by: Julian Alarcon <jalarcon@lendingfront.com>
Co-authored-by: Julian Alarcon <alarconj@gmail.com>
@julian-alarcon julian-alarcon mentioned this issue Sep 20, 2023
Merged
julian-alarcon pushed a commit that referenced this issue Nov 2, 2023
@MagiusCHE
#189 Force nodeIntegration and contextIsolation to let require works …
e1b40fc 
…again.
julian-alarcon pushed a commit that referenced this issue Nov 2, 2023
@MagiusCHE
#189 forced contextIsolation: false and nodeIntegration: true to let …
016357c 
…"require" workson client side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MagiusCHE MagiusCHE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes and features MagiusCHE/prospect-mail
2 participants
@MrDaGree @MagiusCHE