Various fix and improvements #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From ORIGIN
Merge from Julian
…ound (plasma is ignoring tray "click" event).
…nimized; fix settings.getSync default
…require works again.
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
| affinity: 'main-window' | ||
| affinity: 'main-window', | ||
| contextIsolation: false, | ||
| nodeIntegration: true, | ||
| } | ||
| }) |
There was a problem hiding this comment.
opt.semgrep.electron_context_isolation: Disabling context isolation can introduce Prototype Pollution vulnerabilities.
(at-me in a reply with help or ignore)
| affinity: 'main-window' | ||
| affinity: 'main-window', | ||
| contextIsolation: false, | ||
| nodeIntegration: true, | ||
| } | ||
| }) |
There was a problem hiding this comment.
opt.semgrep.electron_nodejs_integration: Node integration exposes node.js APIs to the electron app and this can introduce remote code execution vulnerabilities to the application if the app is vulnerable to Cross Site Scripting (XSS).
(at-me in a reply with help or ignore)
This was referenced Sep 19, 2023
Merged
julian-alarcon
added a commit
that referenced
this pull request
Nov 2, 2023
* Added "Show" to Tray menu to force show window and bring it to foreground (plasma is ignoring tray "click" event). * #193 parse --minimized via commandline to start app minimized; fix settings.getSync default * Fixed trymenu broken setting. Note: hideOnMinimize doesn't work at the moment. * Added minimize option on README Co-authored-by: Julian Alarcon <alarconj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just started to work on various issues and i created this PR to prevent others from working on them.
Here the list of done ones.
--startintrayor--minimized#193