Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only RLInterface.jl interface #29

Closed
zsunberg opened this issue Mar 5, 2020 · 3 comments
Closed

Use only RLInterface.jl interface #29

zsunberg opened this issue Mar 5, 2020 · 3 comments

Comments

@zsunberg
Copy link
Member

zsunberg commented Mar 5, 2020

One of my students discovered that this package uses POMDPs.actionindex. Would it be possible to make the package only use functions from the RLInterface.jl interface? (i.e. we would need to construct our own action map)

@MaximeBouton
Copy link
Contributor

MaximeBouton commented Mar 6, 2020

It is using actionindex to take slices of the batches of q values. It is listed in the requirements I believe.
As soon as the action is taken, it is converted as an integer and stored that way in the buffer.

Where would the custom action map definition be living? Are you suggesting to extend RLInterface or to use the existing actions function?
The solver would need to have access to this ordering somehow.

@zsunberg
Copy link
Member Author

zsunberg commented Mar 6, 2020

I think we would just use the existing actions function. The action map would be internal to the solver. I'll make a PR.

@zsunberg
Copy link
Member Author

zsunberg commented Mar 6, 2020

PR: #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants