Fix defunct dfm call #242
Fix defunct dfm call #242
Conversation
|
Thank you so much for this PR @kbenoit! 🙌 Do I understand correctly that you'd like me to do a tidytext release ASAP? |
| @@ -88,7 +88,8 @@ Note that a tidier is also available for the `dfm` class from the quanteda packa | |||
| library(methods) | |||
|
|
|||
| data("data_corpus_inaugural", package = "quanteda") | |||
| d <- quanteda::dfm(data_corpus_inaugural, verbose = FALSE) | |||
| d <- quanteda::tokens(data_corpus_inaugural) %>% | |||
There was a problem hiding this comment.
I switched to %>% because the package as a whole still does. I'll open an issue about that.
|
That would be great. Esp since quanteda v4 just got published on CRAN.
Sent from Outlook for iOS<https://aka.ms/o0ukef>
…________________________________
From: Julia Silge ***@***.***>
Sent: Thursday, April 4, 2024 8:21:45 PM
To: juliasilge/tidytext ***@***.***>
Cc: Benoit,KR ***@***.***>; Mention ***@***.***>
Subject: Re: [juliasilge/tidytext] Fix defunct dfm call (PR #242)
Thank you so much for this PR @kbenoit<https://github.com/kbenoit>! 🙌
Do I understand correctly that you'd like me to do a tidytext release ASAP?
—
Reply to this email directly, view it on GitHub<#242 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQUYZSHSSR6QBHKPTXO4QDY3WR4TAVCNFSM6AAAAABFR3R466VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGA2DANBRGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Makes perfect sense!
Sent from Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: Julia Silge ***@***.***>
Sent: Thursday, April 4, 2024 8:22:58 PM
To: juliasilge/tidytext ***@***.***>
Cc: Benoit,KR ***@***.***>; Mention ***@***.***>
Subject: Re: [juliasilge/tidytext] Fix defunct dfm call (PR #242)
@juliasilge commented on this pull request.
________________________________
In vignettes/tidying_casting.Rmd<#242 (comment)>:
@@ -88,7 +88,8 @@ Note that a tidier is also available for the `dfm` class from the quanteda packa
library(methods)
data("data_corpus_inaugural", package = "quanteda")
-d <- quanteda::dfm(data_corpus_inaugural, verbose = FALSE)
+d <- quanteda::tokens(data_corpus_inaugural) %>%
I switched to %>% because the package as a whole still does. I'll open an issue about that.
—
Reply to this email directly, view it on GitHub<#242 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQUYZRAGLWPX37NLWKIHXLY3WSBFAVCNFSM6AAAAABFR3R466VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSOBQHE2DSOJWGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
This is failing on R-devel because it can't build the brand new quanteda from source:
|
|
Yes we are actively trying to fix the r-devel (Fedora) platform build issues. It's tricky but hopefully, won't hold up your update. |
|
Looks like waiting has only made the problem worse, actually. 😢 Now CI can't build quanteda on R-release either. @kbenoit do you have any advice on how I can get quanteda up and running in CI? I did get an email from CRAN because of the quanteda release so now tidytext is on a deadline. I can pin an older version of quanteda in CI to get it to pass (right? the older version of quanteda will support the new change in the tidytext vignette?), but of course that defeats the purpose really. |
|
Resubmitted quanteda today, I think we solved it now. New quanteda.textstats on CRAN, also seededlda and proxyC. note to future self: Don't publish a major release right when the r-devel is also a major release! |
|
Success now! 🚀 Thank you so much @kbenoit |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Necessary to unblock CRAN from publishing quanteda v4