Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on MKL_jll.jl #18

Closed
andreasnoack opened this issue Jan 10, 2019 · 7 comments · Fixed by #22
Closed

Add dependency on MKL_jll.jl #18

andreasnoack opened this issue Jan 10, 2019 · 7 comments · Fixed by #22

Comments

@andreasnoack
Copy link
Member

That would make the package work automatically and make it easy to enable CI. MKL.jl overwrites OpenBLAS which currently can cause some issues when using other binary dependencies which require BLAS, e.g. Arpack so we might want to wait a bit. MKL.jl also causes a regression in REPL compile latency but hopefully, I'll be able to fix that soon.

We could probably add MKL.jl as a test dependency here as soon as it has been registered.

@andreasnoack
Copy link
Member Author

Well. We probably don't need to MKL.jl to be registered to use it for testing.

@KristofferC
Copy link
Member

But this package already works automatically (as long as you set the env variables with the mklvars script).

@andreasnoack
Copy link
Member Author

Yeah. I wasn't precise. I meant without a preinstalled MKL.

@arnavs
Copy link

arnavs commented May 24, 2019

Just a question on this issue.

An RA here is working on fleshing out coverage in MKLSparse. The MKL downloads for Mac on Intel's site are broken, so setting the environment variables is impossible. Instead, we decided to install MKL.jl, and then nuke the piece of code that manually links to it (i.e., the __init__().)

Is this correct? (Basically, if you added MKL.jl as a dep, would that init function be irrelevant?)

@KristofferC
Copy link
Member

Update here: What should be done is to depend on MKL_jll and use that (no need to use MKL.jl).

@ywa136
Copy link

ywa136 commented May 5, 2020

Hi guys, a question.

I'm new to Julia, MKL, and MKLSparse. I'm having trouble getting MKLSparse to work because it could not load the library "libmkl_rt". I understand that you mentioned to depend the package on MKL or MKL_jll. But how that exactly works? More specifically, how do I depend MKLSparse to one of those?

Many thanks!

@pablosanjose
Copy link
Member

@ywa136 , what you need to do is install the MKL library (from Intel) in your system, and load the env variables before launching Julia (source /opt/intel/mkl/bin/mklvars.sh intel64 ilp64 or somesuch). What these gentlemen are discussing here is not anything the user needs to do, it is a mechanism to allow, in the future, to download the library automatically so the user doesn't have to. Also, please direct your questions to e.g. discourse.julialang.org, so we can keep github focused on development issues.

@KristofferC KristofferC changed the title Add dependency on MKL.jl Add dependency on MKL_jll.jl Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants