Unit test issues

[miccheng]

1. Dead code

• Unused grids variable in tests

  • graph/graph/src/test/java/com/example/graph/client/GraphDrawTestSuite.java

    Line 91 in 4e3e9f3

    Grid[][] grids = MyCanvas.getInstance().getGrids();

  • graph/graph/src/test/java/com/example/graph/client/GraphDrawTestSuite.java

    Line 69 in 4e3e9f3

    Grid[][] grids = MyCanvas.getInstance().getGrids();

  • graph/graph/src/test/java/com/example/graph/client/GraphDrawTestSuite.java

    Line 48 in 4e3e9f3

    Grid[][] grids = MyCanvas.getInstance().getGrids();

2. Simplify expectation setup

   • You could construct a string instead of the heavy setup:

   String expected = "------\n" +
               "|    |\n" +
               "|    |\n" +
               "|  xx|\n" +
               "------\n";
   assertEquals(expected, actual);

   Instead of:

   graph/graph/src/test/java/com/example/graph/client/GraphDrawTestSuite.java

   Lines 99 to 100 in 4e3e9f3

   	String expected = render.displayGrids(expectedGrids);
   	assertEquals(expected, actual);

3. Test suites that runs multiple tests, you need to reset the canvas.
   

   graph/graph/src/test/java/com/example/graph/client/GraphDrawTestSuite.java

   Line 36 in 4e3e9f3

   MyCanvas.initInstance(4, 3);

[juliatong]

updated