Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Public API Reform] Split $election->getResult methods, for filtering by tags #144

Open
julien-boudry opened this issue Jun 14, 2023 · 0 comments
Open

[Public API Reform] Split $election->getResult methods, for filtering by tags #144

julien-boudry opened this issue Jun 14, 2023 · 0 comments
Assignees
@julien-boudry
Labels
public api reform Mostly breaking change proposal for a better and consitent public api suggestion

Comments

@julien-boudry
Copy link
Owner

julien-boudry commented Jun 14, 2023 •
edited
Loading

Context

Filtering by tags uses the methodOption argument, which is not consistent and complex.
Also, the option keys are ugly, especially in this context.

Proposal

Create getResultWithTagsand getResultWithoutTags, it's more intelligible and more consistent with similar methods.

Breaking changes

(high) Filtering by tags using getResult is no longer supported.
@julien-boudry julien-boudry self-assigned this Jun 14, 2023
@julien-boudry julien-boudry changed the title [Public API Reform] SDplit getResult method [Public API Reform] Split $election->getResult methods, for filtering by tags Jun 14, 2023
@julien-boudry julien-boudry added the public api reform Mostly breaking change proposal for a better and consitent public api label Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julien-boudry julien-boudry

Labels
public api reform Mostly breaking change proposal for a better and consitent public api suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@julien-boudry