Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(template): fix replacement of a multiple occurence of the same variable #46

Merged
merged 1 commit into from
May 7, 2020
Merged

fix(template): fix replacement of a multiple occurence of the same variable #46

merged 1 commit into from
May 7, 2020

Conversation

arnaudbesnier
Copy link
Contributor

@arnaudbesnier arnaudbesnier commented May 7, 2020 •
edited
Loading

Fixes #45

@juliuscc
Copy link
Owner

juliuscc commented May 7, 2020

Good catch! replace is a terrible cause of many bugs.

@juliuscc juliuscc merged commit 73c2238 into juliuscc:master May 7, 2020
@juliuscc
Copy link
Owner

juliuscc commented May 7, 2020

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only the first occurence of a variable is properly set in a string of a custom template
2 participants
@arnaudbesnier @juliuscc