feat: php7.0 minimum requirement #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
.github/workflows/build.yml
Outdated
| @@ -14,7 +14,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-latest] | |||
| php: ['5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1'] | |||
| php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1'] | |||
There was a problem hiding this comment.
Maybe we can add 8.2 also.
Suggested change
| php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1'] | |
| php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2'] |
ricklambrechts
approved these changes
May 3, 2023
src/OpenIDConnectClient.php
Outdated
| */ | ||
| private function getKeyForHeader($keys, $header) { | ||
| private function getKeyForHeader(stdClass $keys, stdClass $header) { |
There was a problem hiding this comment.
Suggested change
| private function getKeyForHeader(stdClass $keys, stdClass $header) { | |
| private function getKeyForHeader(array $keys, stdClass $header): stdClass | |
| { |
src/OpenIDConnectClient.php
Outdated
| if (!class_exists('\phpseclib3\Crypt\RSA') && !class_exists('\phpseclib\Crypt\RSA') && !class_exists('Crypt_RSA')) { | ||
| throw new OpenIDConnectClientException('Crypt_RSA support unavailable.'); | ||
| } | ||
| private function verifyRSAJWTSignature(string $hashType, $key, $payload, $signature, $signatureType): bool |
There was a problem hiding this comment.
Suggested change
| private function verifyRSAJWTSignature(string $hashType, $key, $payload, $signature, $signatureType): bool | |
| private function verifyRSAJWTSignature(string $hashType, stdClass $key, string $payload, string $signature, string $signatureType): bool |
src/OpenIDConnectClient.php
Outdated
| $rsa->loadKey($public_key_xml, Crypt_RSA::PUBLIC_FORMAT_XML); | ||
| $rsa->setSignatureMode($signatureType === 'PSS' ? Crypt_RSA::SIGNATURE_PSS : Crypt_RSA::SIGNATURE_PKCS1); | ||
| return $rsa->verify($payload, $signature); | ||
| $key = PublicKeyLoader::load($key) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Nice update to use RSA::load!
DeepDiver1975
requested review from
ricklambrechts and
azmeuk
and removed request for
ricklambrechts
azmeuk
approved these changes
May 3, 2023
There was a problem hiding this comment.
I won't have time to do extensive testing soon, but just by reading the PR looks good to me.
I agree it is time to move on :) https://endoflife.date/php
Closed
Magentron
added a commit
to Magentron/OpenID-Connect-PHP
that referenced
this pull request
May 22, 2024
* upstream/master: fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373) fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406) fix: Cast SERVER_PORT to integer (jumbojett#404) chore(deps): bump actions/cache from 3 to 4 (jumbojett#417) chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416) docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405) chore: Update ci to support php 8.3 and add dependabot (jumbojett#407) release: 1.0.0 (jumbojett#402) Set the User-Agent regardless of GET or POST (jumbojett#382) fix: Update well known config value function response types (jumbojett#376) feat: set useragent (jumbojett#370) feat: php7.0 minimum requirement (jumbojett#327) # Conflicts: # CHANGELOG.md
Magentron
added a commit
to Magentron/OpenID-Connect-PHP
that referenced
this pull request
May 22, 2024
…est-token * master: fix: Removed duplicate check on jwks_uri and only check if jwks_uri exists when needed (jumbojett#373) fix: Check if subject is equal to subject of id token when verifying JWT claims (jumbojett#406) fix: Cast SERVER_PORT to integer (jumbojett#404) chore(deps): bump actions/cache from 3 to 4 (jumbojett#417) chore(deps): bump actions/checkout from 2 to 4 (jumbojett#416) docs: Update README.md to correct addScope parameter type in 1.0.0 (jumbojett#405) chore: Update ci to support php 8.3 and add dependabot (jumbojett#407) release: 1.0.0 (jumbojett#402) Set the User-Agent regardless of GET or POST (jumbojett#382) fix: Update well known config value function response types (jumbojett#376) feat: set useragent (jumbojett#370) feat: php7.0 minimum requirement (jumbojett#327) updated composer.json added replace, updated README.md added notification about project forked from # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like it is time to move on .... at least a bit.
This should go into a new major version 1.x.x to ensure anybody still being on 0.9.x with php5.x will not run into trouble
List of common tasks a pull request require complete